contacts: fix incorrect profile timestamp after migration #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During %0 to %1 migration, empty profiles have been wrongly migrated with bunted timestamp, causing the subscribers to crash on resubscription due to a failing assert. We fix this by introducing several changes: - bump the state number to %2 - initalize the profile with correct now.bowl timestamp in +on-init - deploy migration to fix affected profiles - re-enable the assertion prohibiting subscriptions to a future-dated profile Additionally, the +subs:pub arm is amended to never generate an empty path list for a fact.
Fang-
approved these changes
Oct 29, 2024
arthyn
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During %0 to %1 migration, empty profiles have been wrongly migrated with bunted timestamp, causing the subscribers to crash on resubscription due to a failing assert. We fix this by introducing several changes:
Additionally, the +subs:pub arm is amended to never generate an empty path list for a fact.